Netdev List
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Andrew Vagin <avagin@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: af_packet: when sending ethernet frames, parse header for skb->protocol
Date: Thu, 8 Aug 2013 23:19:38 +0200	[thread overview]
Message-ID: <20130808211943.EA1E8226BB@mail.nwl.cc> (raw)
In-Reply-To: <20130807220303.GA3478@gmail.com>

Hi,

On Thu, Aug 08, 2013 at 02:03:03AM +0400, Andrew Vagin wrote:
> I compiled the akpm branch of linux-next and found that my virtual
> machine didn't get an IP address by dhcp.
> 
> git bisect said that the problem is in "af_packet: when sending ethernet
> frames, parse header for skb->protocol"
> 
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=0f75b09c798ed00c30d7d5551b896be883bc2aeb
> 
> I have double checked, the VM gets an IP address w/o this patch and it
> does not get an address with this patch.
> 
> Let me know if you need any information to investigate this issue.

Thanks for your investigation. I could reproduce your problem, the
culprit was the skb->data pointer changed as a side effect in
eth_type_trans().

Best wishes, Phil

      reply	other threads:[~2013-08-08 21:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 22:03 af_packet: when sending ethernet frames, parse header for skb->protocol Andrew Vagin
2013-08-08 21:19 ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130808211943.EA1E8226BB@mail.nwl.cc \
    --to=phil@nwl.cc \
    --cc=avagin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox