netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] pptp: fix sparse pointer warning
@ 2013-08-08 17:27 Stephen Hemminger
  2013-08-09 21:15 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2013-08-08 17:27 UTC (permalink / raw)
  To: Dmitry Kozlov, David Miller; +Cc: netdev

callid_sock array is referenced via rcu_dereference and
sparse rcu checks complains about address space mismatch.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/drivers/net/ppp/pptp.c	2013-05-11 15:58:52.472353116 -0700
+++ b/drivers/net/ppp/pptp.c	2013-07-30 14:40:52.602172742 -0700
@@ -47,7 +47,7 @@
 #define MAX_CALLID 65535
 
 static DECLARE_BITMAP(callid_bitmap, MAX_CALLID + 1);
-static struct pppox_sock **callid_sock;
+static struct pppox_sock __rcu **callid_sock;
 
 static DEFINE_SPINLOCK(chan_lock);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] pptp: fix sparse pointer warning
  2013-08-08 17:27 [PATCH net-next] pptp: fix sparse pointer warning Stephen Hemminger
@ 2013-08-09 21:15 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-08-09 21:15 UTC (permalink / raw)
  To: stephen; +Cc: xeb, netdev

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 8 Aug 2013 10:27:14 -0700

> callid_sock array is referenced via rcu_dereference and
> sparse rcu checks complains about address space mismatch.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-09 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 17:27 [PATCH net-next] pptp: fix sparse pointer warning Stephen Hemminger
2013-08-09 21:15 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).