From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: hannes@stressinduktion.org, rientjes@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] af_unix: fix bug on large send()
Date: Sun, 11 Aug 2013 22:02:49 -0700 (PDT) [thread overview]
Message-ID: <20130811.220249.559351679802720229.davem@davemloft.net> (raw)
In-Reply-To: <1376283288.3338.7.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 11 Aug 2013 21:54:48 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> commit e370a723632 ("af_unix: improve STREAM behavior with fragmented
> memory") added a bug on large send() because the
> skb_copy_datagram_from_iovec() call always start from the beginning
> of iovec.
>
> We must instead use the @sent variable to properly skip the
> already processed part.
>
> Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2013-08-12 4:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 21:37 [PATCH 1/2 net-next] af_unix: improve STREAM behavior with fragmented memory Eric Dumazet
2013-08-10 8:16 ` David Miller
2013-08-11 14:06 ` Hannes Frederic Sowa
2013-08-11 14:32 ` Eric Dumazet
2013-08-11 14:37 ` Hannes Frederic Sowa
2013-08-11 14:42 ` Eric Dumazet
2013-08-12 4:54 ` [PATCH net-next] af_unix: fix bug on large send() Eric Dumazet
2013-08-12 5:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130811.220249.559351679802720229.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox