From: David Miller <davem@davemloft.net>
To: b.zolnierkie@samsung.com
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org
Subject: Re: [PATCH] stmmac: fix init_dma_desc_rings() to handle errors
Date: Mon, 12 Aug 2013 22:11:50 -0700 (PDT) [thread overview]
Message-ID: <20130812.221150.1978051574307183933.davem@davemloft.net> (raw)
In-Reply-To: <1392383.ZcinuGX9SF@amdc1032>
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date: Fri, 09 Aug 2013 14:02:08 +0200
> In stmmac_init_rx_buffers():
> * add missing handling of dma_map_single() error
> * remove superfluous unlikely() optimization while at it
>
> Add stmmac_free_rx_buffers() helper and use it in dma_free_rx_skbufs().
>
> In init_dma_desc_rings():
> * add missing handling of kmalloc_array() errors
> * fix handling of dma_alloc_coherent() and stmmac_init_rx_buffers() errors
> * make function return an error value on error and 0 on success
>
> In stmmac_open():
> * add handling of init_dma_desc_rings() return value
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Applied, thanks.
prev parent reply other threads:[~2013-08-13 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 12:02 [PATCH] stmmac: fix init_dma_desc_rings() to handle errors Bartlomiej Zolnierkiewicz
2013-08-09 19:51 ` Denis Kirjanov
2013-08-12 9:36 ` Bartlomiej Zolnierkiewicz
2013-08-12 13:46 ` Denis Kirjanov
2013-08-13 5:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812.221150.1978051574307183933.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b.zolnierkie@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).