Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sarveshwar.bandi@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] be2net: Clear any capability flags that driver is not interested in.
Date: Tue, 13 Aug 2013 15:22:07 -0700 (PDT)	[thread overview]
Message-ID: <20130813.152207.440378568111389533.davem@davemloft.net> (raw)
In-Reply-To: <208f9dff-8e74-4a44-bd94-6c79342e6a73@CMEXHTCAS1.ad.emulex.com>

From: <sarveshwar.bandi@emulex.com>
Date: Mon, 12 Aug 2013 11:21:09 +0530

> From: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>
> 
> It is possible for some versions of firmware to advertise capabilities that driver
> is not ready to handle. This may lead to controller stall. Clear all flags that driver
> is not interested in.
> 
> Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>

This is so ugly and hard to understand.

The issue is that the capabilities come from an external entity, in
be_cmd_get_func_config().

So that's the place where you should clear the bits that the drive
doesn't understand.

Also, put the new macro into a sane place like a header file close
to the existing individual BE_IF_FLAGS_* defines.  And name it sanely,
something like "BE_IF_FLAGS_ALL".

      reply	other threads:[~2013-08-13 22:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12  5:51 [PATCH net] be2net: Clear any capability flags that driver is not interested in sarveshwar.bandi
2013-08-13 22:22 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813.152207.440378568111389533.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sarveshwar.bandi@emulex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox