From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com,
william.manley@youview.com, bcrl@kvack.org,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-next v2] ipv6: make unsolicited report intervals configurable for mld
Date: Tue, 13 Aug 2013 15:52:50 -0700 (PDT) [thread overview]
Message-ID: <20130813.155250.2046252303059223531.davem@davemloft.net> (raw)
In-Reply-To: <20130812112817.GC23241@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Mon, 12 Aug 2013 13:28:17 +0200
> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h
> index 4bda4cf..315f133 100644
> --- a/include/uapi/linux/ipv6.h
> +++ b/include/uapi/linux/ipv6.h
> @@ -147,6 +147,8 @@ enum {
> DEVCONF_MAX_DESYNC_FACTOR,
> DEVCONF_MAX_ADDRESSES,
> DEVCONF_FORCE_MLD_VERSION,
> + DEVCONF_MLDV1_UNSOLICITED_REPORT_INTERVAL,
> + DEVCONF_MLDV2_UNSOLICITED_REPORT_INTERVAL,
> DEVCONF_ACCEPT_RA_DEFRTR,
> DEVCONF_ACCEPT_RA_PINFO,
> DEVCONF_ACCEPT_RA_RTR_PREF,
Since these these values are in an UAPI header, and thus exported to userspace,
you can't add new enumeration values in the middle. Otherwise you'll change
the existing enumerations, which could break userspace.
You'll have to add these new values to the end.
prev parent reply other threads:[~2013-08-13 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 11:28 [PATCH net-next v2] ipv6: make unsolicited report intervals configurable for mld Hannes Frederic Sowa
2013-08-13 22:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813.155250.2046252303059223531.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcrl@kvack.org \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=william.manley@youview.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).