From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: steffen.klassert@secunet.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, vi0oss@gmail.com
Subject: Re: [PATCH net-next v2] xfrm: make local error reporting more robust
Date: Tue, 13 Aug 2013 16:35:07 -0700 (PDT) [thread overview]
Message-ID: <20130813.163507.1784421467479379649.davem@davemloft.net> (raw)
In-Reply-To: <20130813015644.GC27385@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Tue, 13 Aug 2013 03:56:44 +0200
> On Mon, Aug 12, 2013 at 07:54:14AM +0200, Steffen Klassert wrote:
>> On Sat, Aug 10, 2013 at 06:16:29PM +0200, Hannes Frederic Sowa wrote:
>> >
>> > Seems skb->encapsulated helps, but I still have to wire it up for the ipv6
>> > tunnels.
>> >
>> > I just prototyped this patch, but I fear I now introduced a dependency
>> > from core xfrm to ipv6, which I would like to have prevented (this would
>> > even happen if I put xfrm_local_error in a header file). Is this actually
>> > a problem? I fear so. The other way would be to put the local_error
>> > handler as function pointers somewhere reachable from struct sock.
>> >
>>
>> Maybe we should put a local_error() function pointer to struct
>> xfrm_state_afinfo and call it via inner_mode->afinfo->local_error().
>>
>> This should always call the right local_error function and we
>> would not need to touch generic networking code to fix it.
>
> Sorry, had to do a v2, because I missed two more unsafe skb->sk dereferences.
> I will post a further one (unsafe determination of mtu) as a seperate patch
> (needs its own commit message).
>
> [PATCH net-next v2] xfrm: make local error reporting more robust
FWIW, this looks fine to me, and I hope Steffen will take care of
it soon.
prev parent reply other threads:[~2013-08-13 23:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 14:50 [PATCH RFC] xfrm{4,6}: only report errors back to local sockets if we don't cross address family Hannes Frederic Sowa
2013-07-30 8:21 ` Steffen Klassert
2013-07-30 8:30 ` Hannes Frederic Sowa
2013-07-30 10:26 ` Steffen Klassert
2013-07-30 10:40 ` Hannes Frederic Sowa
2013-07-31 0:01 ` David Miller
2013-08-01 8:11 ` Hannes Frederic Sowa
2013-08-01 10:05 ` Steffen Klassert
2013-08-08 22:44 ` Hannes Frederic Sowa
2013-08-08 22:57 ` Eric Dumazet
2013-08-08 23:06 ` Hannes Frederic Sowa
2013-08-10 16:16 ` Hannes Frederic Sowa
2013-08-12 5:54 ` Steffen Klassert
2013-08-13 0:48 ` [PATCH net-next] xfrm: make local error reporting more robust Hannes Frederic Sowa
2013-08-13 1:56 ` [PATCH net-next v2] " Hannes Frederic Sowa
2013-08-13 23:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813.163507.1784421467479379649.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=vi0oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).