From: David Miller <davem@davemloft.net>
To: sonic.adi@gmail.com
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
adi-buildroot-devel@lists.sourceforge.net,
sonic.zhang@analog.com
Subject: Re: [PATCH] driver:net:stmmac: Disable DMA store and forward mode if platform data force_sf_dma_mode is negative.
Date: Thu, 15 Aug 2013 14:20:05 -0700 (PDT) [thread overview]
Message-ID: <20130815.142005.816948927496553829.davem@davemloft.net> (raw)
In-Reply-To: <1376552256-7421-1-git-send-email-sonic.adi@gmail.com>
From: Sonic Zhang <sonic.adi@gmail.com>
Date: Thu, 15 Aug 2013 15:37:36 +0800
> @@ -1157,7 +1157,9 @@ static void free_dma_desc_resources(struct stmmac_priv *priv)
> */
> static void stmmac_dma_operation_mode(struct stmmac_priv *priv)
> {
> - if (likely(priv->plat->force_sf_dma_mode ||
> + if (priv->plat->force_sf_dma_mode < 0)
> + priv->hw->dma->dma_mode(priv->ioaddr, tc, tc);
> + else if (likely(priv->plat->force_sf_dma_mode > 0 ||
> ((priv->plat->tx_coe) && (!priv->no_csum_insertion)))) {
You need to properly re-indent the last line here so that
the openning parenthesis lines up with the first column
after the openning parenthesis on the "else if" line.
next prev parent reply other threads:[~2013-08-15 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 7:37 [PATCH] driver:net:stmmac: Disable DMA store and forward mode if platform data force_sf_dma_mode is negative Sonic Zhang
2013-08-15 21:20 ` David Miller [this message]
2013-08-16 9:37 ` Sonic Zhang
2013-08-17 5:30 ` David Miller
2013-08-19 6:03 ` Giuseppe CAVALLARO
2013-08-19 7:31 ` Sonic Zhang
2013-08-19 7:45 ` Giuseppe CAVALLARO
2013-08-19 10:51 ` Sonic Zhang
2013-08-19 14:29 ` Giuseppe CAVALLARO
2013-08-22 8:40 ` Sonic Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815.142005.816948927496553829.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).