netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: clbchenlibo.chen@huawei.com
Cc: netdev@vger.kernel.org, lizefan@huawei.com, leoli@freescale.com,
	linuxppc-dev@lists.ozlabs.org, pantelis.antoniou@gmail.com,
	vbordug@ru.mvista.com, gregkh@linuxfoundation.org,
	jg1.han@samsung.com, sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH v3 0/7] net: use platform_{get,set}_drvdata()
Date: Thu, 15 Aug 2013 15:39:03 -0700 (PDT)	[thread overview]
Message-ID: <20130815.153903.859166500375208182.davem@davemloft.net> (raw)
In-Reply-To: <20130815.152359.920302339053249583.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Thu, 15 Aug 2013 15:23:59 -0700 (PDT)

> From: Libo Chen <clbchenlibo.chen@huawei.com>
> Date: Thu, 15 Aug 2013 21:01:17 +0800
> 
>> Use the wrapper functions for getting and setting the driver data using
>> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
>> so we can directly pass a struct platform_device.
>> 
>> changelog v3:
>> 	remove modify about dev_set_drvdata()
>> changelog v2:
>> 	this version add modify record about dev_set_drvdata().
> 
> Series applied.

Actually, I had to revert, these patches break the build.

drivers/net/ethernet/sun/sunhme.c: In function ‘happy_meal_pci_probe’:
drivers/net/ethernet/sun/sunhme.c:3114:2: error: implicit declaration of function ‘platform_set_drvdata’ [-Werror=implicit-function-declaration]
drivers/net/ethernet/sun/sunhme.c: In function ‘happy_meal_pci_remove’:
drivers/net/ethernet/sun/sunhme.c:3162:9: error: implicit declaration of function ‘platform_get_drvdata’ [-Werror=implicit-function-declaration]
drivers/net/ethernet/sun/sunhme.c:3162:26: warning: initialization makes pointer from integer without a cast [enabled by default]

  reply	other threads:[~2013-08-15 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 13:01 [PATCH v3 0/7] net: use platform_{get,set}_drvdata() Libo Chen
2013-08-15 22:23 ` David Miller
2013-08-15 22:39   ` David Miller [this message]
2013-08-15 22:51     ` Sergei Shtylyov
2013-08-15 23:04       ` Sergei Shtylyov
2013-08-16  2:15     ` Libo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815.153903.859166500375208182.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=clbchenlibo.chen@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=leoli@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lizefan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pantelis.antoniou@gmail.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=vbordug@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).