netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kongjianjun@gmail.com
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
	jasowang@redhat.com, edumazet@google.com, vyasevic@redhat.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] macvtap: fix up direction in comment on offloading
Date: Thu, 15 Aug 2013 15:39:56 -0700 (PDT)	[thread overview]
Message-ID: <20130815.153956.753981075193965537.davem@davemloft.net> (raw)
In-Reply-To: <CAFeW=paTeaNsvK7ai-PPs6+MVW3LbaPaW9et_eu3XuGPpMqnuw@mail.gmail.com>

From: Amos Kong <kongjianjun@gmail.com>
Date: Fri, 16 Aug 2013 04:41:26 +0800

> On Fri, Aug 16, 2013 at 1:46 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> It speaks about receiving frames, so while
>> it says GSO, it really means GRO.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>  drivers/net/macvtap.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
>> index a98fb0e..a98ed9f 100644
>> --- a/drivers/net/macvtap.c
>> +++ b/drivers/net/macvtap.c
>> @@ -1047,7 +1047,7 @@ static int set_offload(struct macvtap_queue *q, unsigned long arg)
>>          * accept TSO frames and turning it off means that user space
>>          * does not support TSO.
>>          * For macvtap, we have to invert it to mean the same thing.
>> -        * When user space turns off TSO, we turn off GSO/LRO so that
>> +        * When user space turns off TSO, we turn off GRO/LRO so that
> 
> Right fix.
> 
> Reviewed-by: Amos Kong <kongjianjun@gmail.com>

Applied, thanks.

      reply	other threads:[~2013-08-15 22:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 17:46 [PATCH] macvtap: fix up direction in comment on offloading Michael S. Tsirkin
2013-08-15 20:41 ` Amos Kong
2013-08-15 22:39   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815.153956.753981075193965537.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=kongjianjun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).