From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: mleitner@redhat.com, netdev@vger.kernel.org, jiri@resnulli.us,
dbanerje@akamai.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH stable] ipv6: restrict neighbor entry creation to output flow
Date: Thu, 15 Aug 2013 15:54:54 -0700 (PDT) [thread overview]
Message-ID: <20130815.155454.417440388188230172.davem@davemloft.net> (raw)
In-Reply-To: <20130814150054.GB2723@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Wed, 14 Aug 2013 17:00:54 +0200
> On Wed, Aug 14, 2013 at 10:53:27AM -0300, Marcelo Ricardo Leitner wrote:
>> This patch is based on 3.2.y branch, the one used by reported. Please let me
>> know if it should be different. Thanks.
>>
>> ---8<---
>>
>> Commit 0d6a77079c475033cb622c07c5a880b392ef664e introduced a regression on
>> which routes to local delivery would not work anymore. Like this:
>>
>> $ ip -6 route add local 2001::/64 dev lo
>> $ ping6 -c1 2001::9
>> PING 2001::9(2001::9) 56 data bytes
>> ping: sendmsg: Invalid argument
>>
>> As this is a local delivery, that commit would not allow the creation of a
>> neighbor entry and thus the packet cannot be sent.
>>
>> But as TPROXY scenario actually needs to avoid the neighbor entry creation only
>> for input flow, this patch now limits previous patch to input flow, keeping
>> output as before that patch.
>>
>> Reported-by: Debabrata Banerjee <dbavatar@gmail.com>
>> Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
>> CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> Looks good, thanks Marcelo!
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> David, this patch is for all stable kernels except the 3.10 series.
> It does not apply cleanly throughout the whole longterm kernels but the
> changes should not be too difficult to adapt. Do you take care of this
> or can we do something to ease this process?
I've queued it up for -stable, thanks.
next prev parent reply other threads:[~2013-08-15 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 13:53 [PATCH stable] ipv6: restrict neighbor entry creation to output flow Marcelo Ricardo Leitner
2013-08-14 15:00 ` Hannes Frederic Sowa
2013-08-15 22:54 ` David Miller [this message]
2013-08-28 14:09 ` Jiri Pirko
2013-08-28 14:12 ` Hannes Frederic Sowa
2013-08-29 9:21 ` Jiri Pirko
2013-09-09 12:17 ` Jiri Pirko
2013-09-09 17:29 ` David Miller
2013-09-16 21:21 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815.155454.417440388188230172.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dbanerje@akamai.com \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).