From: Martin Schwenke <martin@meltin.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ip monitor: Enable prefix labels when monitoring more than 1 object
Date: Fri, 16 Aug 2013 16:52:13 +1000 [thread overview]
Message-ID: <20130816165213.68c2ea6c@martins.ozlabs.org> (raw)
In-Reply-To: <20130815234047.0018f3dd@nehalam.linuxnetplumber.net>
On Thu, 15 Aug 2013 23:40:47 -0700, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Thu, 15 Aug 2013 07:05:27 +1000
> Martin Schwenke <martin@meltin.net> wrote:
>
> > Prefix labelling is currently only activated when monitoring "all"
> > objects. However, the output can still be confusing when monitoring
> > more than 1 object, so enable prefix labels in this case.
> >
> > Signed-off-by: Martin Schwenke <martin@meltin.net>
>
> I understand where you are coming from, but changing the output format
> might break people with scripts doing parsing the current format.
>
> Since there is already a flag to ip monitor to put on prefix labels,
> why not just use that if you need to?
Sorry, I can't see that option in either the usage message or in the
code. In the current code the only place I can see prefix_banner
being set is in the "all" case. I think "prefix" is about monitoring
IPv6 prefixes or similar.
Perhaps I could add a "label" option instead?
> This seems like a change likely to upset more people than it pleases.
Yeah, perhaps... :-(
peace & happiness,
martin
prev parent reply other threads:[~2013-08-16 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 21:05 [PATCH] ip monitor: Enable prefix labels when monitoring more than 1 object Martin Schwenke
2013-08-16 6:40 ` Stephen Hemminger
2013-08-16 6:52 ` Martin Schwenke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816165213.68c2ea6c@martins.ozlabs.org \
--to=martin@meltin.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).