From: Francois Romieu <romieu@fr.zoreil.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Peter Wu <lekensteyn@gmail.com>,
netdev@vger.kernel.org, nic_swsd <nic_swsd@realtek.com>
Subject: Re: [PATCH v2] r8169: fix invalid register dump
Date: Sat, 17 Aug 2013 23:14:07 +0200 [thread overview]
Message-ID: <20130817211407.GA30676@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1376735258.11042.102.camel@deadeye.wl.decadent.org.uk>
Ben Hutchings <bhutchings@solarflare.com> :
[...]
> I would be very wary of accessing registers with any width other than
> the usual (32 bits).
You are right. Most registers do not seem to care - some are 8 bits
wide - but the 8168c datasheet states that it's out of spec for the
descriptor ring address registers.
Peter, please use Ben's suggestion as is.
--
Ueimor
prev parent reply other threads:[~2013-08-17 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 9:04 [PATCH v2] r8169: fix invalid register dump Peter Wu
2013-08-17 10:27 ` Ben Hutchings
2013-08-17 21:14 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130817211407.GA30676@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=bhutchings@solarflare.com \
--cc=lekensteyn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox