From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: avagin@openvz.org, netdev@vger.kernel.org
Subject: Re: About tcp: set timestamps for restored skb-s
Date: Tue, 20 Aug 2013 13:08:06 -0700 (PDT) [thread overview]
Message-ID: <20130820.130806.2180396135396793576.davem@davemloft.net> (raw)
In-Reply-To: <1376786376.21329.20.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 17 Aug 2013 17:39:36 -0700
> Because of gmail.com problems, I missed lot of netdev traffic
>
> Related to :
>
> http://patchwork.ozlabs.org/patch/267678/
>
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 5423223..b2f6c74 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1121,6 +1121,13 @@ new_segment:
> goto wait_for_memory;
>
> /*
> + * All packets are restored as if they have
> + * already been sent.
> + */
> + if (tp->repair)
> + TCP_SKB_CB(skb)->when = tcp_time_stamp;
> +
>
> The test could be removed.
>
> Setting @when for regular sends seems harmless
I applied this before reading this, sorry.
It can be cleaned up in net-next eventually.
next prev parent reply other threads:[~2013-08-20 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 0:39 About tcp: set timestamps for restored skb-s Eric Dumazet
2013-08-20 20:08 ` David Miller [this message]
2013-08-20 20:30 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820.130806.2180396135396793576.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avagin@openvz.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox