netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lekensteyn@gmail.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
	hayeswang@realtek.com, romieu@fr.zoreil.com
Subject: Re: [PATCH] r8169: remember WOL preferences on driver load
Date: Tue, 20 Aug 2013 15:10:36 -0700 (PDT)	[thread overview]
Message-ID: <20130820.151036.1067735437451172978.davem@davemloft.net> (raw)
In-Reply-To: <1376730002-9235-1-git-send-email-lekensteyn@gmail.com>

From: Peter Wu <lekensteyn@gmail.com>
Date: Sat, 17 Aug 2013 11:00:02 +0200

> From: Peter Wu <lekensteyn@gmail.com>
> 
> Do not clear Broadcast/Multicast/Unicast Wake Flag or LanWake in
> Config5. This is necessary to preserve WOL state when the driver is
> loaded. Although the r8168 vendor driver does not write Config5 (it has
> been commented out), Hayes Wang from Realtek said that masking bits like
> this is more sensible.
> 
> Signed-off-by: Peter Wu <lekensteyn@gmail.com>

Can I get some reviews and Ack's for this?

Thanks.

  reply	other threads:[~2013-08-20 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17  9:00 [PATCH] r8169: remember WOL preferences on driver load Peter Wu
2013-08-20 22:10 ` David Miller [this message]
2013-08-20 23:12   ` Francois Romieu
2013-08-20 23:48     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2013-08-13 20:19 Peter Wu
2013-08-13 21:28 ` Francois Romieu
2013-08-14 12:56   ` Peter Wu
2013-08-15  6:09     ` hayeswang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130820.151036.1067735437451172978.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hayeswang@realtek.com \
    --cc=lekensteyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).