From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org
Subject: Re: [PATCH (net.git) 1/2] stmmac: disable at run-time the EEE if not supported
Date: Tue, 20 Aug 2013 17:04:16 -0700 (PDT) [thread overview]
Message-ID: <20130820.170416.2028716553359945223.davem@davemloft.net> (raw)
In-Reply-To: <52126788.4060607@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 19 Aug 2013 22:44:24 +0400
>> @@ -2166,7 +2181,6 @@ static int stmmac_poll(struct napi_struct *napi,
>> int budget)
>> static void stmmac_tx_timeout(struct net_device *dev)
>> {
>> struct stmmac_priv *priv = netdev_priv(dev);
>> -
>> /* Clear Tx resources and restart transmitting again */
>
> Why? This seems unneeded change.
Agreed, not only was this code properly styled already, changing it
is totally unrelated to what this patch is supposed to be doing.
prev parent reply other threads:[~2013-08-21 0:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 6:38 [PATCH (net.git) 1/2] stmmac: disable at run-time the EEE if not supported Giuseppe CAVALLARO
2013-08-19 6:38 ` [PATCH (net.git) 2/2] stmmac: remove useless csum flag Giuseppe CAVALLARO
2013-08-19 18:44 ` [PATCH (net.git) 1/2] stmmac: disable at run-time the EEE if not supported Sergei Shtylyov
2013-08-21 0:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820.170416.2028716553359945223.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).