Query: Regarding 8211E Phy module support in drivers/net/phy

Query: Regarding 8211E Phy module support in drivers/net/phy

[Sharma Bhupesh-B45370]

Hi Peppe,

This regarding the patch prepared by you for adding RTL8211E support in
drivers/net/phy/realtek.c

commit ef3d90491a15f0d5cf1ec39a38a45dac6968fb2a
Author: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date:   Wed Jan 23 00:30:03 2013 +0000

    net: phy: realtek: add rtl8211e driver
    
    This patch adds the minimal driver to manage the
    Realtek RTL8211E 10/100/1000 Transceivers.

I see a macro specific to 8211E:
+#define        RTL8211E_INER_LINK_STAT 0x10

I was having a look at the RTL8211E(G) datasheet and could see
the following bit positions for INER register (Address 0x12):

[7:1] as Reserved
[0] as Jabber Interrupt

If I am not wrong a value 0x10 written to the INER register tries to set bit [4] which seems
Reserved.

Or am I missing something here.
Please let me know your views on the same.

Thanks,
Bhupesh 

Re: Query: Regarding 8211E Phy module support in drivers/net/phy

[Giuseppe CAVALLARO]

On 8/2/2013 8:50 PM, Sharma Bhupesh-B45370 wrote:
> Hi Peppe,
>
> This regarding the patch prepared by you for adding RTL8211E support in
> drivers/net/phy/realtek.c
>
> commit ef3d90491a15f0d5cf1ec39a38a45dac6968fb2a
> Author: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date:   Wed Jan 23 00:30:03 2013 +0000
>
>      net: phy: realtek: add rtl8211e driver
>
>      This patch adds the minimal driver to manage the
>      Realtek RTL8211E 10/100/1000 Transceivers.
>
> I see a macro specific to 8211E:
> +#define        RTL8211E_INER_LINK_STAT 0x10
>
> I was having a look at the RTL8211E(G) datasheet and could see
> the following bit positions for INER register (Address 0x12):
>
> [7:1] as Reserved
> [0] as Jabber Interrupt
>
> If I am not wrong a value 0x10 written to the INER register tries to set bit [4] which seems
> Reserved.

Hello Sharma
you are right RTL8211E_INER_LINK_STAT should be 0x400
I will test it again (just to find the hw) and prepare/send a new patch.

Many thanks

peppe

>
> Or am I missing something here.
> Please let me know your views on the same.
>
> Thanks,
> Bhupesh
>
>
>

RE: Query: Regarding 8211E Phy module support in drivers/net/phy

[Sharma Bhupesh-B45370]

> -----Original Message-----
> From: Giuseppe CAVALLARO [mailto:peppe.cavallaro@st.com]
> Sent: Wednesday, August 14, 2013 7:38 PM
> To: Sharma Bhupesh-B45370
> Cc: 'netdev@vger.kernel.org'
> Subject: Re: Query: Regarding 8211E Phy module support in drivers/net/phy
> 
> On 8/2/2013 8:50 PM, Sharma Bhupesh-B45370 wrote:
> > Hi Peppe,
> >
> > This regarding the patch prepared by you for adding RTL8211E support
> > in drivers/net/phy/realtek.c
> >
> > commit ef3d90491a15f0d5cf1ec39a38a45dac6968fb2a
> > Author: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> > Date:   Wed Jan 23 00:30:03 2013 +0000
> >
> >      net: phy: realtek: add rtl8211e driver
> >
> >      This patch adds the minimal driver to manage the
> >      Realtek RTL8211E 10/100/1000 Transceivers.
> >
> > I see a macro specific to 8211E:
> > +#define        RTL8211E_INER_LINK_STAT 0x10
> >
> > I was having a look at the RTL8211E(G) datasheet and could see the
> > following bit positions for INER register (Address 0x12):
> >
> > [7:1] as Reserved
> > [0] as Jabber Interrupt
> >
> > If I am not wrong a value 0x10 written to the INER register tries to
> > set bit [4] which seems Reserved.
> 
> Hello Sharma
> you are right RTL8211E_INER_LINK_STAT should be 0x400 I will test it
> again (just to find the hw) and prepare/send a new patch.
>

Hi Peppe,

Glad to hear from you. Please test with the h/w and send the relevant patch
as I plan to send a patch supporting a new RTL phy module rebased on top of your patch.

Thanks for your help.
Regards,
Bhupesh

 
> Many thanks
> 
> peppe
> 
> >
> > Or am I missing something here.
> > Please let me know your views on the same.
> >
> > Thanks,
> > Bhupesh
> >
> >
> >
> 

RE: Query: Regarding 8211E Phy module support in drivers/net/phy

[Sharma Bhupesh-B45370]

Hi Peppe,

Ping.. Any updates on this?

> -----Original Message-----
> From: Sharma Bhupesh-B45370
> Sent: Thursday, August 15, 2013 1:48 AM
> To: 'Giuseppe CAVALLARO'
> Cc: 'netdev@vger.kernel.org'
> Subject: RE: Query: Regarding 8211E Phy module support in drivers/net/phy
> 
> 
> > -----Original Message-----
> > From: Giuseppe CAVALLARO [mailto:peppe.cavallaro@st.com]
> > Sent: Wednesday, August 14, 2013 7:38 PM
> > To: Sharma Bhupesh-B45370
> > Cc: 'netdev@vger.kernel.org'
> > Subject: Re: Query: Regarding 8211E Phy module support in
> > drivers/net/phy
> >
> > On 8/2/2013 8:50 PM, Sharma Bhupesh-B45370 wrote:
> > > Hi Peppe,
> > >
> > > This regarding the patch prepared by you for adding RTL8211E support
> > > in drivers/net/phy/realtek.c
> > >
> > > commit ef3d90491a15f0d5cf1ec39a38a45dac6968fb2a
> > > Author: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> > > Date:   Wed Jan 23 00:30:03 2013 +0000
> > >
> > >      net: phy: realtek: add rtl8211e driver
> > >
> > >      This patch adds the minimal driver to manage the
> > >      Realtek RTL8211E 10/100/1000 Transceivers.
> > >
> > > I see a macro specific to 8211E:
> > > +#define        RTL8211E_INER_LINK_STAT 0x10
> > >
> > > I was having a look at the RTL8211E(G) datasheet and could see the
> > > following bit positions for INER register (Address 0x12):
> > >
> > > [7:1] as Reserved
> > > [0] as Jabber Interrupt
> > >
> > > If I am not wrong a value 0x10 written to the INER register tries to
> > > set bit [4] which seems Reserved.
> >
> > Hello Sharma
> > you are right RTL8211E_INER_LINK_STAT should be 0x400 I will test it
> > again (just to find the hw) and prepare/send a new patch.
> >
> 
> Hi Peppe,
> 
> Glad to hear from you. Please test with the h/w and send the relevant
> patch as I plan to send a patch supporting a new RTL phy module rebased
> on top of your patch.
> 
> Thanks for your help.
> Regards,
> Bhupesh
> 
> 
> > Many thanks
> >
> > peppe
> >
> > >
> > > Or am I missing something here.
> > > Please let me know your views on the same.
> > >
> > > Thanks,
> > > Bhupesh
> > >
> > >
> > >
> >

Regards,
Bhupesh

[PATCH (net.git)] net: phy: rtl8211: fix interrupt on status link change

[Giuseppe CAVALLARO]

This is to fix a problem in the rtl8211 where the driver
wasn't properly enabled the interrupt on link change status.
it has to enable the ineterrupt on the bit 10 in the register 18
(INER).

Reported-by: Sharma Bhupesh <B45370@freescale.com>
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
 drivers/net/phy/realtek.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 8e7af83..138de83 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -23,7 +23,7 @@
 #define RTL821x_INER_INIT	0x6400
 #define RTL821x_INSR		0x13
 
-#define	RTL8211E_INER_LINK_STAT	0x10
+#define	RTL8211E_INER_LINK_STATUS	0x400
 
 MODULE_DESCRIPTION("Realtek PHY driver");
 MODULE_AUTHOR("Johnson Leung");
@@ -57,7 +57,7 @@ static int rtl8211e_config_intr(struct phy_device *phydev)
 
 	if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
 		err = phy_write(phydev, RTL821x_INER,
-				RTL8211E_INER_LINK_STAT);
+				RTL8211E_INER_LINK_STATUS);
 	else
 		err = phy_write(phydev, RTL821x_INER, 0);
 
-- 
1.7.4.4

Re: [PATCH (net.git)] net: phy: rtl8211: fix interrupt on status link change

[David Miller]

From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Mon, 19 Aug 2013 08:48:34 +0200

> This is to fix a problem in the rtl8211 where the driver
> wasn't properly enabled the interrupt on link change status.
> it has to enable the ineterrupt on the bit 10 in the register 18
> (INER).
> 
> Reported-by: Sharma Bhupesh <B45370@freescale.com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>

Applied, thanks.