Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: vytautas.valancius@gmail.com, valas@google.com,
	edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Passing sk_buff metadata information to user space in TUNTAP driver.
Date: Tue, 20 Aug 2013 23:28:36 -0700 (PDT)	[thread overview]
Message-ID: <20130820.232836.1603560215048485459.davem@davemloft.net> (raw)
In-Reply-To: <CAHo-Ooy4S8tzOBqZQJEEvkAqMJdYCf2XTYZpkFHk=PZJP7z-Ng@mail.gmail.com>

From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Mon, 19 Aug 2013 13:49:08 -0700

> Acked-by: Maciej Żenczykowski <maze@google.com>
> 
> I've already reviewed / commented on previous versions of this patch
> and am hoping for comments from a wider audience.
> 
> I'm hoping this relatively generic and easily extensible way of
> exposing additional per-packet metadata to userspace catches on.
> Something similar would also be useful for tcpdump (ie. raw packet sockets).

I'd rather people build generic infrastructure for this.

We already have a META match in the packet scheduler, and all sorts
of BPF extensions which provide SKB metadata too.  That's the right
approach, something more generic.

Therefore, putting a custom version of SKB metadata export into the
TUN driver makes absolutely no sense to me.

I'm not applying this, sorry.

      reply	other threads:[~2013-08-21  6:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 20:29 [PATCH] Passing sk_buff metadata information to user space in TUNTAP driver Valas Valancius
2013-08-19 20:49 ` Maciej Żenczykowski
2013-08-21  6:28   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130820.232836.1603560215048485459.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=valas@google.com \
    --cc=vytautas.valancius@gmail.com \
    --cc=zenczykowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox