From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: netdev@vger.kernel.org
Subject: No more checkpatch "fixes" from newer developers.
Date: Tue, 20 Aug 2013 23:44:21 -0700 (PDT) [thread overview]
Message-ID: <20130820.234421.235463717243281849.davem@davemloft.net> (raw)
I've really had it with "checkpatch" fixes that break things.
Case in point, the recent ipv6 checkpatch fixes did this:
/* first try to inherit the link-local address from the link device */
- if (idev->dev->iflink &&
- (link_dev = __dev_get_by_index(net, idev->dev->iflink))) {
- if (!ipv6_inherit_linklocal(idev, link_dev))
+ if (idev->dev->iflink)
+ link_dev = __dev_get_by_index(net, idev->dev->iflink);
+ if (link_dev && !ipv6_inherit_linklocal(idev, link_dev))
return;
- }
+
Are you kidding me? The openning and closing curly braces that create
the basic block were erroneously removed. Now the value of link_dev
is not defined.
I'm reverting this, and don't bother submitting these kinds of changes
any more, I'm going to ignore them.
reply other threads:[~2013-08-21 6:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820.234421.235463717243281849.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).