Re: [PATCH 0/3] net: propagate dynamic needed_headroom/tailroom changes

[Jiri Pirko <jiri@resnulli.us>]

Tue, Aug 20, 2013 at 02:45:49PM CEST, f.fainelli@gmail.com wrote:
>Hi all,
>
>This patchset aims at allowing dynamically changing a given device
>needed_headroom/tailroom space and propagating such events to stacked
>devices such as bridges and vlans.

You should also add support for other stacked devices, like bonding,
team, macvlan, ovs-datapath, etc.	
	
>
>Unless callers use the new helpers (dev_set_headroom/dev_set_tailroom)
>there is no functional change introduced.
>
>I tested this with an out of tree Ethernet driver with both VLANs and
>bridges and the need for a 64-byte headroom to insert a transmit
>status descriptor in front of a SKB.

Would be nice to add at least one driver which would use your new api.

Thanks,
	Jiri

>
>Since I am not familiar with all subsystems/drivers changing the
>needed_headroom/tailroom requirements, I would leave that to them.
>
>Florian Fainelli (3):
>  net: add a new NETDEV_CHANGEROOM event type
>  net: vlan: handle NETDEV_CHANGEROOM events
>  net: bridge: handle NETDEV_CHANGEROOM event
>
> include/linux/netdevice.h |  3 +++
> net/8021q/vlan.c          |  7 +++++++
> net/bridge/br_if.c        | 32 ++++++++++++++++++++++++++++++++
> net/bridge/br_notify.c    |  5 +++++
> net/bridge/br_private.h   |  2 ++
> net/core/dev.c            | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 95 insertions(+)
>
>-- 
>1.8.1.2
>
>