From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: "Berg, Johannes" <johannes.berg@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Gao feng <gaofeng@cn.fujitsu.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next] netlink: prevent deadlock in ctrl_dumpfamily()
Date: Tue, 20 Aug 2013 22:31:17 +0300 [thread overview]
Message-ID: <20130820193117.GA2239@swordfish> (raw)
In-Reply-To: <1DC40B07CD6EC041A66726C271A73AE61AA6F1BC@IRSMSX102.ger.corp.intel.com>
On (08/20/13 14:03), Berg, Johannes wrote:
> > + if (need_locking) {
> > + /* genl_mutex could be already locked in genl_rcv_msg() */
> > + rt = genl_family_find_byid(cb->nlh->nlmsg_type);
> > + need_locking = need_locking && rt->parallel_ops;
> > + }
>
> This is equivalent to reverting the patch because parallel_ops will be false for the genl family. :-)
>
sorry, didn't notice that there is already a thread on lkml regarding
this issue. will follow that discussion. the reason was that I see an
actual deadlock on my machine during certain network activities, but
lockdep is silent.
thanks,
-ss
> johannes
> --
>
> Intel GmbH
> Dornacher Strasse 1
> 85622 Feldkirchen/Muenchen, Deutschland
> Sitz der Gesellschaft: Feldkirchen bei Muenchen
> Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
> Registergericht: Muenchen HRB 47456
> Ust.-IdNr./VAT Registration No.: DE129385895
> Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
>
prev parent reply other threads:[~2013-08-20 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 13:50 [PATCH next] netlink: prevent deadlock in ctrl_dumpfamily() Sergey Senozhatsky
2013-08-20 14:03 ` Berg, Johannes
2013-08-20 19:31 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820193117.GA2239@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=davem@davemloft.net \
--cc=gaofeng@cn.fujitsu.com \
--cc=johannes.berg@intel.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).