Netdev List
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH V3] ipv6: handle Redirect ICMP Message with no Redirected Header option
Date: Wed, 21 Aug 2013 13:17:00 +0200	[thread overview]
Message-ID: <20130821111700.GE20223@order.stressinduktion.org> (raw)
In-Reply-To: <521468C4.5020700@cn.fujitsu.com>

On Wed, Aug 21, 2013 at 03:14:12PM +0800, Duan Jiong wrote:
> From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> 
> rfc 4861 says the Redirected Header option is optional, so
> the kernel should not drop the Redirect Message that has no
> Redirected Header option. In this patch, the function
> ip6_redirect_no_header() is introduced to deal with that
> condition.
> 
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>

Sorry for being so picky about local socket delivery before. You were right
all along.

I just tested and reviewed this patch and everything is fine:

Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

Just out of curiosity, can you tell because of which devices you did
this patch?

Thanks,

  Hannes

  reply	other threads:[~2013-08-21 11:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  7:14 [PATCH V3] ipv6: handle Redirect ICMP Message with no Redirected Header option Duan Jiong
2013-08-21 11:17 ` Hannes Frederic Sowa [this message]
2013-08-22  1:28   ` Duan Jiong
2013-08-22  3:44 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130821111700.GE20223@order.stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=davem@davemloft.net \
    --cc=duanj.fnst@cn.fujitsu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox