From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, tgraf@suug.ch, johannes.berg@intel.com
Subject: Re: [PATCH 1/2] Revert "genetlink: fix family dump race"
Date: Thu, 22 Aug 2013 13:26:31 -0700 (PDT) [thread overview]
Message-ID: <20130822.132631.2273195424430844661.davem@davemloft.net> (raw)
In-Reply-To: <1377094083-8122-2-git-send-email-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 21 Aug 2013 16:08:02 +0200
> From: Johannes Berg <johannes.berg@intel.com>
>
> This reverts commit 58ad436fcf49810aa006016107f494c9ac9013db.
>
> It turns out that the change introduced a potential deadlock
> by causing a locking dependency with netlink's cb_mutex. I
> can't seem to find a way to resolve this without doing major
> changes to the locking, so revert this.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
So I've applied this since everyone agrees that we should revert
this change.
How to deal with the problem we were attempting to solve is still
under discussion. It seems that even if we go to RCU we must also
address to module reference count issue.
I think the existing locking is very messy, and RCU looks a lot
cleaner and has potential for future improvements to the scalability
of dumps.
So I'd like to propose that we combine Johannes's RCU conversion
with some variant of the module reference count fix.
Can you guys work together and come up with something I can apply?
Thanks.
next prev parent reply other threads:[~2013-08-22 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 14:08 [PATCH 0/2] fix generic netlink locking issue(s) Johannes Berg
2013-08-21 14:08 ` [PATCH 1/2] Revert "genetlink: fix family dump race" Johannes Berg
2013-08-22 4:29 ` Pravin Shelar
2013-08-22 20:26 ` David Miller [this message]
2013-08-22 20:36 ` Johannes Berg
2013-08-22 21:27 ` Pravin Shelar
2013-08-21 14:08 ` [PATCH 2/2] genetlink: convert family dump code to use RCU Johannes Berg
2013-08-22 4:32 ` Pravin Shelar
2013-08-22 7:17 ` Johannes Berg
2013-08-21 19:05 ` [PATCH 0/2] fix generic netlink locking issue(s) Oliver Hartkopp
2013-08-21 22:53 ` Pravin Shelar
2013-08-22 6:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822.132631.2273195424430844661.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).