* [PATCH 1/2] ethernet: moxa: remove unnecessary platform_set_drvdata()
@ 2013-08-22 1:55 Jingoo Han
2013-08-22 1:57 ` [PATCH 2/2] ethernet: broadcom: " Jingoo Han
2013-08-22 22:12 ` [PATCH 1/2] ethernet: moxa: " David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Jingoo Han @ 2013-08-22 1:55 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jonas Jensen', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/moxa/moxart_ether.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index 6eee686..83c2091 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -533,7 +533,6 @@ static int moxart_remove(struct platform_device *pdev)
unregister_netdev(ndev);
free_irq(ndev->irq, ndev);
moxart_mac_free_memory(ndev);
- platform_set_drvdata(pdev, NULL);
free_netdev(ndev);
return 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ethernet: broadcom: remove unnecessary platform_set_drvdata()
2013-08-22 1:55 [PATCH 1/2] ethernet: moxa: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-22 1:57 ` Jingoo Han
2013-08-22 22:12 ` David Miller
2013-08-22 22:12 ` [PATCH 1/2] ethernet: moxa: " David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-08-22 1:57 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Maxime Bizon', 'Florian Fainelli',
'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index b1bcd4b..ca963d4 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -2836,7 +2836,6 @@ static int bcm_enetsw_remove(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
- platform_set_drvdata(pdev, NULL);
free_netdev(dev);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ethernet: moxa: remove unnecessary platform_set_drvdata()
2013-08-22 1:55 [PATCH 1/2] ethernet: moxa: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 1:57 ` [PATCH 2/2] ethernet: broadcom: " Jingoo Han
@ 2013-08-22 22:12 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2013-08-22 22:12 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, jonas.jensen
From: Jingoo Han <jg1.han@samsung.com>
Date: Thu, 22 Aug 2013 10:55:21 +0900
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ethernet: broadcom: remove unnecessary platform_set_drvdata()
2013-08-22 1:57 ` [PATCH 2/2] ethernet: broadcom: " Jingoo Han
@ 2013-08-22 22:12 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-08-22 22:12 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, mbizon, florian
From: Jingoo Han <jg1.han@samsung.com>
Date: Thu, 22 Aug 2013 10:57:20 +0900
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-22 22:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 1:55 [PATCH 1/2] ethernet: moxa: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 1:57 ` [PATCH 2/2] ethernet: broadcom: " Jingoo Han
2013-08-22 22:12 ` David Miller
2013-08-22 22:12 ` [PATCH 1/2] ethernet: moxa: " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).