From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org, ebiederm@xmission.com, tgraf@infradead.org
Subject: Re: [PATCH net] ipv4: expose IPV4_DEVCONF
Date: Thu, 22 Aug 2013 20:30:36 -0700 (PDT) [thread overview]
Message-ID: <20130822.203036.1163035239116579220.davem@davemloft.net> (raw)
In-Reply-To: <20130821210947.3ef36570@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 21 Aug 2013 21:09:47 -0700
> IP sends device configuration (see inet_fill_link_af) as an array
> in the netlink information, but the indices in that array are not
> exposed to userspace through any current santized header file.
>
> It was available back in 2.6.32 (in /usr/include/linux/sysctl.h)
> but was broken by:
> commit 02291680ffba92e5b5865bc0c5e7d1f3056b80ec
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Sun Feb 14 03:25:51 2010 +0000
>
> net ipv4: Decouple ipv4 interface parameters from binary sysctl numbers
>
> Eric was solving the sysctl problem but then the indices were re-exposed
> by a later addition of devconf support for IPV4
>
> commit 9f0f7272ac9506f4c8c05cc597b7e376b0b9f3e4
> Author: Thomas Graf <tgraf@infradead.org>
> Date: Tue Nov 16 04:32:48 2010 +0000
>
> ipv4: AF_INET link address family
>
> Putting them in /usr/include/linux/ip.h seemed the logical match
> for the DEVCONF_ definitions for IPV6 in /usr/include/linux/ip6.h
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Looks good, applied, thanks Stephen.
prev parent reply other threads:[~2013-08-23 3:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 4:09 [PATCH net] ipv4: expose IPV4_DEVCONF Stephen Hemminger
2013-08-23 3:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822.203036.1163035239116579220.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).