From: Steffen Klassert <steffen.klassert@secunet.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Problematic commits in the ipsec tree
Date: Thu, 22 Aug 2013 12:47:24 +0200 [thread overview]
Message-ID: <20130822104724.GD26773@secunet.com> (raw)
Hannes,
I have two problematic commits from you in the ipsec tree. The first one is:
commit 0ea9d5e3e (xfrm: introduce helper for safe determination of mtu)
This breakes pmtu discovery for IPv4 because now we use the device mtu
instead of the reduced IPsec mtu in xfrm4_tunnel_check_size() if a IPv4
socket is at the skb.
The second is:
commit 844d48746 (xfrm: choose protocol family by skb protocol)
This breaks pmtu discovery for IPv6 too because skb->protocol can be null
in __xfrm6_output().
We need a solution soon, or I have to revert or remove these commits from
the ipsec tree.
next reply other threads:[~2013-08-22 10:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 10:47 Steffen Klassert [this message]
2013-08-22 11:21 ` Problematic commits in the ipsec tree Hannes Frederic Sowa
2013-08-22 13:53 ` Hannes Frederic Sowa
2013-08-23 8:58 ` Steffen Klassert
2013-08-23 11:03 ` Hannes Frederic Sowa
2013-08-23 11:34 ` Hannes Frederic Sowa
2013-08-23 12:49 ` Hannes Frederic Sowa
2013-08-26 9:41 ` Steffen Klassert
2013-08-26 10:46 ` Hannes Frederic Sowa
2013-08-22 19:53 ` [PATCH ipsec 1/2] xfrm: revert ipv4 mtu determination to dst_mtu Hannes Frederic Sowa
2013-08-22 19:54 ` [PATCH ipsec 2/2] ipv6: set skb->protocol on tcp, raw and ip6_append_data genereated skbs Hannes Frederic Sowa
2013-08-22 23:59 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822104724.GD26773@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).