From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH 2/2] Rename nsproxy.pid_ns to nsproxy.pid_ns_for_children Date: Thu, 22 Aug 2013 20:56:05 +0200 Message-ID: <20130822185605.GA24890@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Eric W. Biederman" , security@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Andy Lutomirski Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 08/22, Andy Lutomirski wrote: > > nsproxy.pid_ns is *not* the task's pid namespace. The name should clarify > that. > > This makes it more obvious that setns on a pid namespace is weird -- > it won't change the pid namespace shown in procfs. > > ... > > + * The pid namespace is an exception -- it's accessed using > + * task_active_pid_ns. The pid namespace here is the > + * namespace that children will use. > + * > * 'count' is the number of tasks holding a reference. > * The count for each namespace, then, will be the number > * of nsproxies pointing to it, not the number of tasks. > @@ -27,7 +31,7 @@ struct nsproxy { > struct uts_namespace *uts_ns; > struct ipc_namespace *ipc_ns; > struct mnt_namespace *mnt_ns; > - struct pid_namespace *pid_ns; > + struct pid_namespace *pid_ns_for_children; > struct net *net_ns; Personally I agree. ->pid_ns is "strange" and it makes sense to document and make clear the fact that it became the implicit argument for clone(). Oleg.