From: David Miller <davem@davemloft.net>
To: fan.du@windriver.com
Cc: steffen.klassert@secunet.com, saurabh.mohan@vyatta.com,
herbert@gondor.hengli.com.au, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] {ipv4,xfrm}: Introduce xfrm_tunnel_notifier for xfrm tunnel mode callback
Date: Mon, 26 Aug 2013 16:21:35 -0400 (EDT) [thread overview]
Message-ID: <20130826.162135.1765443562851401512.davem@davemloft.net> (raw)
In-Reply-To: <1377240424-11758-1-git-send-email-fan.du@windriver.com>
From: Fan Du <fan.du@windriver.com>
Date: Fri, 23 Aug 2013 14:47:04 +0800
> Some thoughts on IPv4 VTI implementation:
>
> The connection between VTI receiving part and xfrm tunnel mode input process
> is hardly a "xfrm_tunnel", xfrm_tunnel is used in places where, e.g ipip/sit
> and xfrm4_tunnel, acts like a true "tunnel" device.
>
> In addition, IMHO, VTI doesn't need vti_err to do something meaningful, as all
> VTI needs is just a notifier to be called whenever xfrm_input ingress a packet
> to update statistics.
>
> So this patch introduce xfrm_tunnel_notifier and meanwhile wipe out vti_erri
> code.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
I don't understand why VTI doesn't need to propagate a PMTU update via
ipv4_update_pmtu(). Why is it different from a real xfrm_tunnel?
Your changelog has to explain this better and in more detail.
Thanks.
next prev parent reply other threads:[~2013-08-26 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 6:47 [PATCH net-next] {ipv4,xfrm}: Introduce xfrm_tunnel_notifier for xfrm tunnel mode callback Fan Du
2013-08-26 11:35 ` Steffen Klassert
2013-08-27 1:40 ` Fan Du
2013-08-26 20:21 ` David Miller [this message]
2013-08-27 1:29 ` Fan Du
2013-08-27 9:28 ` Steffen Klassert
2013-08-27 16:23 ` David Miller
2013-08-27 1:52 ` Saurabh Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826.162135.1765443562851401512.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=saurabh.mohan@vyatta.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).