From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: mrkiko.rs@gmail.com, gregkh@linuxfoundation.org,
oliver@neukum.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver
Date: Mon, 26 Aug 2013 16:58:31 -0400 (EDT) [thread overview]
Message-ID: <20130826.165831.112649899191508957.davem@davemloft.net> (raw)
In-Reply-To: <1377549913.1877.12.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Mon, 26 Aug 2013 13:45:13 -0700
> I think the premise of local variable
> declaration by line length is flawed.
I disagree.
> It can't work when local variables are
> dependent on initialization order as
> above.
Move the initialization below the declarations.
next prev parent reply other threads:[~2013-08-26 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 7:56 [PATCH RESEND V3 net-next 0/3] huawei_cdc_ncm driver introduction Enrico Mioso
2013-08-23 7:56 ` [PATCH RESEND V3 net-next 1/3] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use Enrico Mioso
2013-08-23 7:56 ` [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver Enrico Mioso
2013-08-26 20:31 ` David Miller
2013-08-26 20:45 ` Joe Perches
2013-08-26 20:58 ` David Miller [this message]
2013-08-26 21:05 ` Joe Perches
2013-08-26 21:09 ` David Miller
2013-08-26 21:25 ` Joe Perches
2013-08-27 6:52 ` Enrico Mioso
2013-08-23 7:56 ` [PATCH RESEND V3 net-next 3/3] net: cdc_ncm: remove non-standard NCM device IDs Enrico Mioso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826.165831.112649899191508957.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).