From: Rob Gardner <robmatic@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, bjorn@mork.no,
oliver@neukum.org
Subject: Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table
Date: Wed, 28 Aug 2013 18:40:22 -0600 [thread overview]
Message-ID: <20130828184022.9a5b54e8df63aaf8c82bf9b5@gmail.com> (raw)
In-Reply-To: <20130828.200111.1548126886406334118.davem@davemloft.net>
On Wed, 28 Aug 2013 20:01:11 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Rob Gardner <robmatic@gmail.com>
> Date: Wed, 28 Aug 2013 17:18:12 -0600
>
> > Bjørn says it could have a minor performance impact, but should not
> > cause any loss of functionality. I don't think there's any hard data on
> > what the performance cost might be but I know he would eventually like
> > to get rid of the exception list and live with the possible performance
> > impact if it means functionality for more devices.
>
> Therefore I would recommend turning the workaround on by default and
> have a white list.
The exception list means "usb_device_id entries for specific devices
that are known to need the workaround." There are just two such entries.
There isn't even a separate list. So maybe we just have a nomenclature
problem, and we could simply be calling this a "white list" instead of
"exception list". The other possible meaning of whitelist (all devices
that *don't* need the workaround) is unthinkable, as that would be a huge
list and much more prone to be unmanageable than what we've got now.
--
Rob Gardner <robmatic@gmail.com>
next prev parent reply other threads:[~2013-08-29 0:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 0:29 [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table Rob Gardner
[not found] ` <20130825182913.2865aa1a8cefe329ab9c7a85-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-26 1:10 ` Bjørn Mork
2013-08-28 22:23 ` David Miller
2013-08-28 23:18 ` Rob Gardner
[not found] ` <20130828171812.7097dc8334046b464486d4a3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-29 0:01 ` David Miller
2013-08-29 0:40 ` Rob Gardner [this message]
[not found] ` <20130828184022.9a5b54e8df63aaf8c82bf9b5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-29 4:33 ` David Miller
[not found] ` <20130829.003352.1187611479213752660.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-08-29 5:51 ` Rob Gardner
2013-08-29 8:32 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828184022.9a5b54e8df63aaf8c82bf9b5@gmail.com \
--to=robmatic@gmail.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox