From: David Miller <davem@davemloft.net>
To: maxime.ripard@free-electrons.com
Cc: jszhang@marvell.com, emilio@elopez.com.ar,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mdio-sun4i: Convert to devm_* api
Date: Thu, 29 Aug 2013 14:55:13 -0400 (EDT) [thread overview]
Message-ID: <20130829.145513.179529840926907721.davem@davemloft.net> (raw)
In-Reply-To: <20130828093508.GQ2695@lukather>
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Wed, 28 Aug 2013 11:35:08 +0200
> Hi Jisheng,
>
> On Mon, Aug 26, 2013 at 09:11:57PM +0800, Jisheng Zhang wrote:
>> Use devm_ioremap_resource instead of of_iomap() and devm_kzalloc()
>> instead of kmalloc() to make cleanup paths simpler. This patch also
>> fixes the resource leak caused by missing corresponding iounamp()
>> of the of_iomap().
>>
>> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> It looks fine for me.
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2013-08-29 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 13:11 [PATCH] net: mdio-sun4i: Convert to devm_* api Jisheng Zhang
2013-08-28 9:35 ` Maxime Ripard
2013-08-29 18:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829.145513.179529840926907721.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=emilio@elopez.com.ar \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).