From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] virtio-net: Set RXCSUM feature if GUEST_CSUM is available Date: Thu, 29 Aug 2013 15:57:04 -0400 (EDT) Message-ID: <20130829.155704.248095796202059854.davem@davemloft.net> References: <1377616142-29590-1-git-send-email-thuth@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, mst@redhat.com, virtualization@lists.linux-foundation.org To: thuth@linux.vnet.ibm.com Return-path: In-Reply-To: <1377616142-29590-1-git-send-email-thuth@linux.vnet.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Thomas Huth Date: Tue, 27 Aug 2013 17:09:02 +0200 > If the VIRTIO_NET_F_GUEST_CSUM virtio feature is available, the guest > does not have to calculate the checksums on all received packets. This > is pretty much the same feature as RX checksum offloading on real > network cards, so the virtio-net driver should report this by setting > the NETIF_F_RXCSUM flag. When the user now runs "ethtool -k", he or she > can see whether the virtio-net interface has to calculate RX checksums > or not. > > Signed-off-by: Thomas Huth Can one of the virtio_net folks please review this? Thanks.