From: David Miller <davem@davemloft.net>
To: chris.clark@alcatel-lucent.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: sendto/hdrincl: don't use destination address found in header
Date: Thu, 29 Aug 2013 15:59:46 -0400 (EDT) [thread overview]
Message-ID: <20130829.155946.2289111569129635752.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1308271153040.2079@optio.utah.ind.alcatel.com>
From: Chris Clark <chris.clark@alcatel-lucent.com>
Date: Tue, 27 Aug 2013 12:02:15 -0600 (MDT)
>
> ipv4: raw_sendmsg: don't use header's destination address
>
> A sendto() regression was bisected and found to start with commit
> f8126f1d5136be1 (ipv4: Adjust semantics of rt->rt_gateway.)
>
> The problem is that it tries to ARP-lookup the constructed packet's
> destination address rather than the explicitly provided address.
>
> Fix this using FLOWI_FLAG_KNOWN_NH so that given nexthop is used.
>
> cf. commit 2ad5b9e4bd314fc685086b99e90e5de3bc59e26b
>
> Reported-by: Chris Clark <chris.clark@alcatel-lucent.com>
> Bisected-by: Chris Clark <chris.clark@alcatel-lucent.com>
> Tested-by: Chris Clark <chris.clark@alcatel-lucent.com>
> Suggested-by: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Chris Clark <chris.clark@alcatel-lucent.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-08-29 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 18:02 [PATCH] ipv4: sendto/hdrincl: don't use destination address found in header Chris Clark
2013-08-29 19:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829.155946.2289111569129635752.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.clark@alcatel-lucent.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).