From: David Miller <davem@davemloft.net>
To: kmcmarti@redhat.com
Cc: rob.herring@calxeda.com, netdev@vger.kernel.org
Subject: Re: [PATCH] xgmac: use bufsz not dma_buf_sz in rx_refill
Date: Thu, 29 Aug 2013 16:38:35 -0400 (EDT) [thread overview]
Message-ID: <20130829.163835.1514973445858189297.davem@davemloft.net> (raw)
In-Reply-To: <20130829203523.GL8764@redacted.bos.redhat.com>
From: Kyle McMartin <kmcmarti@redhat.com>
Date: Thu, 29 Aug 2013 16:35:23 -0400
> On Thu, Aug 29, 2013 at 04:34:37PM -0400, David Miller wrote:
>> From: Kyle McMartin <kyle@redhat.com>
>> Date: Thu, 29 Aug 2013 16:11:51 -0400
>>
>> > Noticed while debugging another issue that DMA debug turned up, looks
>> > like commit ef468d23 missed a case when switching to bufsz instead of
>> > priv->dma_buf_sz? (tbf, the whole handling of DMA buffers seems slightly
>> > suspect since we're not tracking the size, but trusting the hardware
>> > between map and unmap...)
>> >
>> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
>>
>> Applied and queued up for -stable, thanks.
>
> Heh, too fast David, Rob nak'd it. :)
>
> Sorry about that.
If Rob had resubmitted his series in a timely manner this wouldn't
have happened.
I reverted.
next prev parent reply other threads:[~2013-08-29 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 20:11 [PATCH] xgmac: use bufsz not dma_buf_sz in rx_refill Kyle McMartin
2013-08-29 20:24 ` Rob Herring
2013-08-29 20:26 ` Kyle McMartin
2013-08-29 20:38 ` David Miller
2013-08-29 20:31 ` Sergei Shtylyov
2013-08-29 20:34 ` David Miller
2013-08-29 20:35 ` Kyle McMartin
2013-08-29 20:38 ` David Miller [this message]
2013-08-30 3:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829.163835.1514973445858189297.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kmcmarti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).