From: Kyle McMartin <kyle@redhat.com>
To: rob.herring@calxeda.com
Cc: netdev@vger.kernel.org
Subject: [PATCH] xgmac: use bufsz not dma_buf_sz in rx_refill
Date: Thu, 29 Aug 2013 16:11:51 -0400 [thread overview]
Message-ID: <20130829201151.GJ8764@redacted.bos.redhat.com> (raw)
Noticed while debugging another issue that DMA debug turned up, looks
like commit ef468d23 missed a case when switching to bufsz instead of
priv->dma_buf_sz? (tbf, the whole handling of DMA buffers seems slightly
suspect since we're not tracking the size, but trusting the hardware
between map and unmap...)
Signed-off-by: Kyle McMartin <kyle@redhat.com>
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -686,7 +686,7 @@ static void xgmac_rx_refill(struct xgmac_priv *priv)
priv->rx_skbuff[entry] = skb;
paddr = dma_map_single(priv->device, skb->data,
bufsz, DMA_FROM_DEVICE);
- desc_set_buf_addr(p, paddr, priv->dma_buf_sz);
+ desc_set_buf_addr(p, paddr, bufsz);
}
netdev_dbg(priv->dev, "rx ring: head %d, tail %d\n",
next reply other threads:[~2013-08-29 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 20:11 Kyle McMartin [this message]
2013-08-29 20:24 ` [PATCH] xgmac: use bufsz not dma_buf_sz in rx_refill Rob Herring
2013-08-29 20:26 ` Kyle McMartin
2013-08-29 20:38 ` David Miller
2013-08-29 20:31 ` Sergei Shtylyov
2013-08-29 20:34 ` David Miller
2013-08-29 20:35 ` Kyle McMartin
2013-08-29 20:38 ` David Miller
2013-08-30 3:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829201151.GJ8764@redacted.bos.redhat.com \
--to=kyle@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).