From: David Miller <davem@davemloft.net>
To: jbohac@suse.cz
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: ICMPv6: treat dest unreachable codes 5 and 6 as EACCES, not EPROTO
Date: Tue, 03 Sep 2013 22:12:24 -0400 (EDT) [thread overview]
Message-ID: <20130903.221224.1469516113963270002.davem@davemloft.net> (raw)
In-Reply-To: <20130830091844.GA2706@midget.suse.cz>
From: Jiri Bohac <jbohac@suse.cz>
Date: Fri, 30 Aug 2013 11:18:45 +0200
> RFC 4443 has defined two additional codes for ICMPv6 type 1 (destination
> unreachable) messages:
> 5 - Source address failed ingress/egress policy
> 6 - Reject route to destination
>
> Now they are treated as protocol error and icmpv6_err_convert() converts them
> to EPROTO.
>
> RFC 4443 says:
> "Codes 5 and 6 are more informative subsets of code 1."
>
> Treat codes 5 and 6 as code 1 (EACCES)
>
> Btw, connect() returning -EPROTO confuses firefox, so that fallback to
> other/IPv4 addresses does not work:
> https://bugzilla.mozilla.org/show_bug.cgi?id=910773
>
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-09-04 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 9:18 ICMPv6: treat dest unreachable codes 5 and 6 as EACCES, not EPROTO Jiri Bohac
2013-09-01 18:54 ` Hannes Frederic Sowa
2013-09-04 2:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903.221224.1469516113963270002.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).