public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Thomas Graf <tgraf@suug.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v2] ipv6: Don't depend on per socket memory for neighbour discovery messages
Date: Tue, 3 Sep 2013 13:56:36 +0200	[thread overview]
Message-ID: <20130903115635.GA21729@order.stressinduktion.org> (raw)
In-Reply-To: <e4600dac657e1160da7a5e7758dcb973b616a10e.1378207925.git.tgraf@suug.ch>

Hi!

On Tue, Sep 03, 2013 at 01:37:01PM +0200, Thomas Graf wrote:
> @@ -389,6 +386,11 @@ static struct sk_buff *ndisc_alloc_skb(struct net_device *dev,
>  	skb_reserve(skb, hlen + sizeof(struct ipv6hdr));
>  	skb_reset_transport_header(skb);
>  
> +	/* Manually assign socket ownership as we avoid calling
> +	 * sock_alloc_send_pskb() to bypass wmem buffer limits
> +	 */
> +	skb_set_owner_w(skb, sk);
> +
>  	return skb;
>  }

Do you know why this is needed? From the report it seemed to me that we might
have a deadlock on idev->lock and I couldn't find the culprit.

When I tested your change on x86_64 I did not experience this.

Maybe someone with arm could try this patch with CONFIG_PROVE_LOCKING?

Thanks,

  Hannes

  reply	other threads:[~2013-09-03 11:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 11:37 [PATCH v2] ipv6: Don't depend on per socket memory for neighbour discovery messages Thomas Graf
2013-09-03 11:56 ` Hannes Frederic Sowa [this message]
2013-09-03 12:11   ` Thomas Graf
2013-09-03 12:18 ` Fabio Estevam
2013-09-03 17:19 ` Stephen Warren
2013-09-03 17:27   ` Hannes Frederic Sowa
2013-09-03 17:42     ` Stephen Warren
2013-09-03 17:51       ` Eric Dumazet
2013-09-03 18:03         ` Stephen Warren
2013-09-03 18:23           ` Thomas Graf
2013-09-03 18:30             ` Hannes Frederic Sowa
2013-09-03 22:43             ` Hannes Frederic Sowa
2013-09-04 18:41 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903115635.GA21729@order.stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=festevam@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox