Re: [PATCH v2] ipv6: Don't depend on per socket memory for neighbour discovery messages

Hannes Frederic Sowa
2013-09-03T22:43:49Z

On Tue, Sep 03, 2013 at 07:23:48PM +0100, Thomas Graf wrote:
> I'm confused why lockdep would only trigger after my patch, the
> deadlock is unrelated.

Either we had patch caf92bc ("ipv6: do not call ndisc_send_rs() with write
lock") already applied or both our testing was flawed. I reverted caf92bc and
tested v1 again and could also reproduce this problem.

Because of the sk_mc_loop logic I do think it is better to set skb->sk, so:

Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

If this should still go to stable, the above mentioned commit should also hit
the queue.

Greetings,

Hannes