From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Thomas Graf <tgraf@suug.ch>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v2] ipv6: Don't depend on per socket memory for neighbour discovery messages
Date: Wed, 4 Sep 2013 00:43:48 +0200 [thread overview]
Message-ID: <20130903224348.GA31185@order.stressinduktion.org> (raw)
In-Reply-To: <20130903182348.GB4166@casper.infradead.org>
On Tue, Sep 03, 2013 at 07:23:48PM +0100, Thomas Graf wrote:
> I'm confused why lockdep would only trigger after my patch, the
> deadlock is unrelated.
Either we had patch caf92bc ("ipv6: do not call ndisc_send_rs() with write
lock") already applied or both our testing was flawed. I reverted caf92bc and
tested v1 again and could also reproduce this problem.
Because of the sk_mc_loop logic I do think it is better to set skb->sk, so:
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
If this should still go to stable, the above mentioned commit should also hit
the queue.
Greetings,
Hannes
next prev parent reply other threads:[~2013-09-03 22:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 11:37 [PATCH v2] ipv6: Don't depend on per socket memory for neighbour discovery messages Thomas Graf
2013-09-03 11:56 ` Hannes Frederic Sowa
2013-09-03 12:11 ` Thomas Graf
2013-09-03 12:18 ` Fabio Estevam
2013-09-03 17:19 ` Stephen Warren
2013-09-03 17:27 ` Hannes Frederic Sowa
2013-09-03 17:42 ` Stephen Warren
2013-09-03 17:51 ` Eric Dumazet
2013-09-03 18:03 ` Stephen Warren
2013-09-03 18:23 ` Thomas Graf
2013-09-03 18:30 ` Hannes Frederic Sowa
2013-09-03 22:43 ` Hannes Frederic Sowa [this message]
2013-09-04 18:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903224348.GA31185@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox