From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH net-next v2 4/8] net: ipv6: mld: implement RFC3810 MLDv2 mode only Date: Wed, 4 Sep 2013 01:01:27 +0200 Message-ID: <20130903230127.GA32732@order.stressinduktion.org> References: <1378246784-21067-1-git-send-email-dborkman@redhat.com> <1378246784-21067-5-git-send-email-dborkman@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: davem@davemloft.net, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from order.stressinduktion.org ([87.106.68.36]:35732 "EHLO order.stressinduktion.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933127Ab3ICXB2 (ORCPT ); Tue, 3 Sep 2013 19:01:28 -0400 Content-Disposition: inline In-Reply-To: <1378246784-21067-5-git-send-email-dborkman@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Sep 04, 2013 at 12:19:40AM +0200, Daniel Borkmann wrote: > RFC3810, 10. Security Considerations says under subsection 10.1. > Query Message: > > A forged Version 1 Query message will put MLDv2 listeners on that > link in MLDv1 Host Compatibility Mode. This scenario can be avoided > by providing MLDv2 hosts with a configuration option to ignore > Version 1 messages completely. > > Hence, implement a MLDv2-only mode that will ignore MLDv1 traffic: > > echo 2 > /proc/sys/net/ipv6/conf/ethX/force_mld_version or > echo 2 > /proc/sys/net/ipv6/conf/all/force_mld_version > > Note that device has a higher precedence as it was previously > also the case in the macro MLD_V1_SEEN() that would "short-circuit" > if condition on case. > > Signed-off-by: Daniel Borkmann > Cc: Hannes Frederic Sowa Even better... Acked-by: Hannes Frederic Sowa Thanks!