From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch] x25: add a sanity check parsing X.25 facilities Date: Wed, 04 Sep 2013 00:54:19 -0400 (EDT) Message-ID: <20130904.005419.700065648971320112.davem@davemloft.net> References: <20130903090340.GB4351@elgon.mountain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew.hendry@gmail.com, linux-x25@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: dan.carpenter@oracle.com Return-path: In-Reply-To: <20130903090340.GB4351@elgon.mountain> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Dan Carpenter Date: Tue, 3 Sep 2013 12:03:40 +0300 > This was found with a manual audit and I don't have a reproducer. We > limit ->calling_len and ->called_len when we get them from > copy_from_user() in x25_ioctl() so when they come from skb->data then > we should cap them there as well. > > Signed-off-by: Dan Carpenter Applied.