From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: michele@acksyn.org, netdev@vger.kernel.org,
yoshfuji@linux-ipv6.org, sasha.levin@oracle.com
Subject: Re: [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl_add
Date: Wed, 04 Sep 2013 14:13:01 -0400 (EDT) [thread overview]
Message-ID: <20130904.141301.41040920905693536.davem@davemloft.net> (raw)
In-Reply-To: <20130903001331.GA8820@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Tue, 3 Sep 2013 02:13:31 +0200
> Hi!
>
> On Mon, Sep 02, 2013 at 10:31:28PM +0100, Michele Baldessari wrote:
>> with the latest linux master git tree from Linus
>> (248d296d6d9df384996c2ed95676b367d876d48c - 2 Sep) I can reproduceably oops
>> the kernel with the following commands:
>> ip addrlabel flush
>> ip addrlabel add prefix ::1/128 label 0
>> ip addrlabel add prefix ::/0 label 1
>
> Thanks for the report! This patch should fix this issue:
>
> [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl_add
>
> Commit b67bfe0d42cac56c512dd5da4b1b347a23f4b70a ("hlist: drop
> the node parameter from iterators") changed the behavior of
> hlist_for_each_entry_safe to leave the p argument NULL.
>
> Fix this up by tracking the last argument.
>
> Reported-by: Michele Baldessari <michele@acksyn.org>
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Cc: Sasha Levin <sasha.levin@oracle.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied.
next prev parent reply other threads:[~2013-09-04 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 21:31 3.11rc7 net/ipv6 addrlabel OOPS Michele Baldessari
2013-09-03 0:13 ` [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl_add Hannes Frederic Sowa
2013-09-03 8:04 ` Michele Baldessari
2013-09-04 18:13 ` David Miller [this message]
2013-09-04 18:51 ` Hannes Frederic Sowa
2013-09-04 18:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904.141301.41040920905693536.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=michele@acksyn.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).