From: Jiri Benc <jbenc@redhat.com>
To: Jean Sacren <sakiwit@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Daniel Borkmann <dborkman@redhat.com>,
davem@davemloft.net, netdev@vger.kernel.org,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net] net: ipv6: tcp: fix potential use after free in tcp_v6_do_rcv
Date: Wed, 4 Sep 2013 08:26:39 +0200 [thread overview]
Message-ID: <20130904082639.5c5e3bb4@griffin> (raw)
In-Reply-To: <20130904005157.GG8262@mail.gmail.com>
On Tue, 3 Sep 2013 18:51:57 -0600, Jean Sacren wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 03 Sep 2013 15:29:12 -0700
> >
> > On Tue, 2013-09-03 at 15:59 -0600, Jean Sacren wrote:
> > > From: Eric Dumazet <eric.dumazet@gmail.com>
> > > Date: Tue, 03 Sep 2013 13:35:17 -0700
> > > >
> > > > How did you get your conclusion ?
> > >
> > > If one changes one line of code, doesn't one own that line?
> > >
> >
> > 'Owning' like he is the guy who can sell it ? OK I understand now
> > so many people send 'cleanups' ;)
>
> 'Owning' like he is the guy who is responsible for the change. Whether
> you understand it or not, that's your own business.
>
> The idea was by taking one example to determine who is really to blame
> for: Is the one passing on the bug responsible? Thanks to Daniel
> Borkmann for the answer.
Eric is correct, the bug was introduced by me.
Sorry for it. Daniel, thanks for fixing it.
Acked-by: Jiri Benc <jbenc@redhat.com>
--
Jiri Benc
next prev parent reply other threads:[~2013-09-04 6:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 17:29 [PATCH net] net: ipv6: tcp: fix potential use after free in tcp_v6_do_rcv Daniel Borkmann
2013-09-03 17:48 ` Eric Dumazet
2013-09-03 19:46 ` Jean Sacren
2013-09-03 20:35 ` Eric Dumazet
2013-09-03 21:59 ` Jean Sacren
2013-09-03 22:25 ` Daniel Borkmann
2013-09-03 22:29 ` Eric Dumazet
2013-09-04 0:51 ` Jean Sacren
2013-09-04 6:26 ` Jiri Benc [this message]
2013-09-04 18:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904082639.5c5e3bb4@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sakiwit@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).