From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl_add Date: Wed, 4 Sep 2013 20:51:45 +0200 Message-ID: <20130904185145.GC13136@order.stressinduktion.org> References: <20130902213128.GB14301@marquez.int.rhx> <20130903001331.GA8820@order.stressinduktion.org> <20130904.141301.41040920905693536.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: michele@acksyn.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, sasha.levin@oracle.com To: David Miller Return-path: Received: from order.stressinduktion.org ([87.106.68.36]:37696 "EHLO order.stressinduktion.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759751Ab3IDSvr (ORCPT ); Wed, 4 Sep 2013 14:51:47 -0400 Content-Disposition: inline In-Reply-To: <20130904.141301.41040920905693536.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Sep 04, 2013 at 02:13:01PM -0400, David Miller wrote: > From: Hannes Frederic Sowa > Date: Tue, 3 Sep 2013 02:13:31 +0200 > > > Hi! > > > > On Mon, Sep 02, 2013 at 10:31:28PM +0100, Michele Baldessari wrote: > >> with the latest linux master git tree from Linus > >> (248d296d6d9df384996c2ed95676b367d876d48c - 2 Sep) I can reproduceably oops > >> the kernel with the following commands: > >> ip addrlabel flush > >> ip addrlabel add prefix ::1/128 label 0 > >> ip addrlabel add prefix ::/0 label 1 > > > > Thanks for the report! This patch should fix this issue: > > > > [PATCH] ipv6: fix null pointer dereference in __ip6addrlbl_add > > > > Commit b67bfe0d42cac56c512dd5da4b1b347a23f4b70a ("hlist: drop > > the node parameter from iterators") changed the behavior of > > hlist_for_each_entry_safe to leave the p argument NULL. > > > > Fix this up by tracking the last argument. > > > > Reported-by: Michele Baldessari > > Cc: Hideaki YOSHIFUJI > > Cc: Sasha Levin > > Signed-off-by: Hannes Frederic Sowa > > Applied. Sorry I forgot to mention that this patch is also applicable to solve this issue in the longterm 3.10 kernel. Maybe this should go to stable? Thanks, Hannes