* rtl8188eu array/null comparison.
@ 2013-09-04 23:30 Dave Jones
2013-09-05 3:14 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-09-04 23:30 UTC (permalink / raw)
To: netdev; +Cc: Larry.Finger
Hi Larry,
in drivers/staging/rtl8188eu/core/rtw_mlme.c:rtw_check_join_candidate there's this code..
1721 /* check ssid, if needed */
1722 if (pmlmepriv->assoc_ssid.Ssid && pmlmepriv->assoc_ssid.SsidLength) {
1723 if (competitor->network.Ssid.SsidLength != pmlmepriv->assoc_ssid.SsidLength ||
1724 _rtw_memcmp(competitor->network.Ssid.Ssid, pmlmepriv->assoc_ssid.Ssid, pmlmepriv->assoc_ssid.SsidLength) == false)
1725 goto exit;
1726 }
1727
assoc_ssid.Ssid being an array, this comparison against null probably isn't what was intended ?
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: rtl8188eu array/null comparison.
2013-09-04 23:30 rtl8188eu array/null comparison Dave Jones
@ 2013-09-05 3:14 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2013-09-05 3:14 UTC (permalink / raw)
To: Dave Jones; +Cc: netdev
On 09/04/2013 06:30 PM, Dave Jones wrote:
> Hi Larry,
>
> in drivers/staging/rtl8188eu/core/rtw_mlme.c:rtw_check_join_candidate there's this code..
>
> 1721 /* check ssid, if needed */
> 1722 if (pmlmepriv->assoc_ssid.Ssid && pmlmepriv->assoc_ssid.SsidLength) {
> 1723 if (competitor->network.Ssid.SsidLength != pmlmepriv->assoc_ssid.SsidLength ||
> 1724 _rtw_memcmp(competitor->network.Ssid.Ssid, pmlmepriv->assoc_ssid.Ssid, pmlmepriv->assoc_ssid.SsidLength) == false)
> 1725 goto exit;
> 1726 }
> 1727
>
> assoc_ssid.Ssid being an array, this comparison against null probably isn't what was intended ?
I think that a non-zero SsidLength should be enough of a test, but I need to
think about a bit more.
Thanks,
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-05 3:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 23:30 rtl8188eu array/null comparison Dave Jones
2013-09-05 3:14 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).