netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Vineet.Gupta1@synopsys.com
Cc: netdev@vger.kernel.org, Alexey.Brodkin@synopsys.com,
	linux-kernel@vger.kernel.org, arc-linux-dev@synopsys.com
Subject: Re: [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies
Date: Thu, 05 Sep 2013 14:25:30 -0400 (EDT)	[thread overview]
Message-ID: <20130905.142530.732425484460470485.davem@davemloft.net> (raw)
In-Reply-To: <1378295235-18928-1-git-send-email-vgupta@synopsys.com>

From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Date: Wed, 4 Sep 2013 17:17:15 +0530

> copying large files to a NFS mounted host was taking absurdly large
> time.
> 
> Turns out that TX BD reclaim had a sublte bug.
> 
> Loop starts off from @txbd_dirty cursor and stops when it hits a BD
> still in use by controller. However when it stops it needs to keep the
> cursor at that very BD to resume scanning in next iteration. However it
> was erroneously incrementing the cursor, causing the next scan(s) to
> fail too, unless the BD chain was completely drained out.
> 
> [ARCLinux]$ ls -l -sh /disk/log.txt
>  17976 -rw-r--r--    1 root     root       17.5M Sep  /disk/log.txt
> 
> ========== Before =====================
> [ARCLinux]$ time cp /disk/log.txt /mnt/.
> real    31m 7.95s
> user    0m 0.00s
> sys     0m 0.10s
> 
> ========== After =====================
> [ARCLinux]$ time cp /disk/log.txt /mnt/.
> real    0m 24.33s
> user    0m 0.00s
> sys     0m 0.19s
> 
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>

Applied.

  reply	other threads:[~2013-09-05 18:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 11:47 [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies Vineet Gupta
2013-09-05 18:25 ` David Miller [this message]
2013-09-10  6:27   ` Vineet Gupta
2013-09-16  5:43     ` Vineet Gupta
2013-09-16 19:40       ` greg Kroah-Hartman
2013-09-17  4:07         ` Vineet Gupta
2013-09-17  4:17           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905.142530.732425484460470485.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=arc-linux-dev@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).