* [PATCH] icplus: Use netif_running to determine device state
@ 2013-09-04 18:26 Jon Mason
2013-09-05 18:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jon Mason @ 2013-09-04 18:26 UTC (permalink / raw)
To: netdev; +Cc: Francois Romieu, Sorbica Shieh
Remove the __LINK_STATE_START check to verify the device is running, in
favor of netif_running(). netif_running() performs the same check of
__LINK_STATE_START, so the code should behave the same.
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Cc: Francois Romieu <romieu@fr.zoreil.com>
Cc: Sorbica Shieh <sorbica@icplus.com.tw>
---
drivers/net/ethernet/icplus/ipg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/icplus/ipg.c b/drivers/net/ethernet/icplus/ipg.c
index 1fde90b..bdf5023 100644
--- a/drivers/net/ethernet/icplus/ipg.c
+++ b/drivers/net/ethernet/icplus/ipg.c
@@ -1004,7 +1004,7 @@ static struct net_device_stats *ipg_nic_get_stats(struct net_device *dev)
/* Check to see if the NIC has been initialized via nic_open,
* before trying to read statistic registers.
*/
- if (!test_bit(__LINK_STATE_START, &dev->state))
+ if (!netif_running(dev))
return &sp->stats;
sp->stats.rx_packets += ipg_r32(IPG_FRAMESRCVDOK);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] icplus: Use netif_running to determine device state
2013-09-04 18:26 [PATCH] icplus: Use netif_running to determine device state Jon Mason
@ 2013-09-05 18:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-09-05 18:27 UTC (permalink / raw)
To: jdmason; +Cc: netdev, romieu, sorbica
From: Jon Mason <jdmason@kudzu.us>
Date: Wed, 4 Sep 2013 11:26:01 -0700
> Remove the __LINK_STATE_START check to verify the device is running, in
> favor of netif_running(). netif_running() performs the same check of
> __LINK_STATE_START, so the code should behave the same.
>
> Signed-off-by: Jon Mason <jdmason@kudzu.us>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-05 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 18:26 [PATCH] icplus: Use netif_running to determine device state Jon Mason
2013-09-05 18:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).