From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: netdev@vger.kernel.org, dev@openvswitch.org, azhou@nicira.com,
fengguang.wu@intel.com, geert@linux-m68k.org
Subject: Re: [PATCH] openvswitch: Fix alignment of struct sw_flow_key.
Date: Thu, 05 Sep 2013 15:54:53 -0400 (EDT) [thread overview]
Message-ID: <20130905.155453.1868210686010920876.davem@davemloft.net> (raw)
In-Reply-To: <1378408625-18415-1-git-send-email-jesse@nicira.com>
From: Jesse Gross <jesse@nicira.com>
Date: Thu, 5 Sep 2013 12:17:05 -0700
> sw_flow_key alignment was declared as " __aligned(__alignof__(long))".
> However, this breaks on the m68k architecture where long is 32 bit in
> size but 16 bit aligned by default. This aligns to the size of a long to
> ensure that we can always do comparsions in full long-sized chunks. It
> also adds an additional build check to catch any reduction in alignment.
>
> CC: Andy Zhou <azhou@nicira.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
Applied, thanks.
next prev parent reply other threads:[~2013-09-05 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 19:17 [PATCH] openvswitch: Fix alignment of struct sw_flow_key Jesse Gross
2013-09-05 19:25 ` Geert Uytterhoeven
2013-09-05 19:54 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-05 17:41 Jesse Gross
2013-09-05 18:17 ` David Miller
2013-09-05 18:36 ` Jesse Gross
[not found] ` <CAEP_g=8gcCtkv=no=HkVmS+NDWPM-Uu-SVyR+vb-YQ=7TWJsXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-05 18:40 ` David Miller
[not found] ` <20130905.144044.1053960608071929025.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-09-05 19:14 ` Jesse Gross
2013-09-05 19:20 ` Geert Uytterhoeven
2013-09-05 19:25 ` Jesse Gross
2013-09-05 19:49 ` David Miller
2013-09-05 19:47 ` Joe Perches
2013-09-06 10:18 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905.155453.1868210686010920876.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=azhou@nicira.com \
--cc=dev@openvswitch.org \
--cc=fengguang.wu@intel.com \
--cc=geert@linux-m68k.org \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).