From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH net] net: netlink: filter particular protocols from analyzers
Date: Thu, 05 Sep 2013 16:07:02 -0400 (EDT) [thread overview]
Message-ID: <20130905.160702.669092815001539896.davem@davemloft.net> (raw)
In-Reply-To: <5228E2A0.4010607@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Thu, 05 Sep 2013 21:59:28 +0200
> On 09/05/2013 09:54 PM, David Miller wrote:
>> From: Daniel Borkmann <dborkman@redhat.com>
>> Date: Thu, 05 Sep 2013 21:48:00 +0200
>>
>>> With socket(PF_PACKET, ..., htons(ETH_P_ALL)) you will already get
>>> all users from the suggested white-list of the patch, which is the
>>> majority of netlink users I believe. Hence, you do not need to have
>>> one socket per protocol. skbs from there should get dragged into
>>> pf_packet via dev_queue_xmit_nit() which works on ptype_all list.
>>
>> What about user level netlink protocols?
>
> If you are referring to NETLINK_USERSOCK, then we let this pass here,
> so nothing changes.
Ok I need to think about this some more, I moved your patch back into under review
state.
next prev parent reply other threads:[~2013-09-05 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 15:48 [PATCH net] net: netlink: filter particular protocols from analyzers Daniel Borkmann
2013-09-05 18:44 ` David Miller
2013-09-05 18:57 ` Stephen Hemminger
2013-09-05 19:03 ` David Miller
2013-09-05 19:44 ` Stephen Hemminger
2013-09-05 19:50 ` David Miller
2013-09-05 19:48 ` Daniel Borkmann
2013-09-05 19:54 ` David Miller
2013-09-05 19:59 ` Daniel Borkmann
2013-09-05 20:07 ` David Miller [this message]
2013-09-06 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905.160702.669092815001539896.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).