From: Dave Jones <davej@redhat.com>
To: netdev@vger.kernel.org
Subject: question about __udp6_lib_err usage of __udp6_lib_lookup
Date: Wed, 4 Sep 2013 22:44:34 -0400 [thread overview]
Message-ID: <20130905024434.GA8219@redhat.com> (raw)
__udp6_lib_lookup's prototype is ...
struct sock *__udp6_lib_lookup(struct net *net,
const struct in6_addr *saddr, __be16 sport,
const struct in6_addr *daddr, __be16 dport,
int dif, struct udp_table *udptable)
But the usage in __udp6_lib_err is...
521 sk = __udp6_lib_lookup(dev_net(skb->dev), daddr, uh->dest,
522 saddr, uh->source, inet6_iif(skb), udptable);
With the source/dest addr/port arguments swapped. Is this intentional ?
Dave
next reply other threads:[~2013-09-05 2:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 2:44 Dave Jones [this message]
2013-09-05 3:21 ` question about __udp6_lib_err usage of __udp6_lib_lookup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905024434.GA8219@redhat.com \
--to=davej@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox